chore: upgrade axe-core from 4.1.2 to 4.3.2

chanzuckerberg · Jul 29, 2021 · 213e146 · 213e146
1 parent c5f6375
commit 213e146
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 6 deletions.
diff --git a/packages/components/package-lock.json b/packages/components/package-lock.json
diff --git a/packages/components/package.json b/packages/components/package.json
@@ -74,7 +74,7 @@
     "@types/jest": "^26.0.24",
     "@types/react": "^17.0.2",
     "autoprefixer": "^10.2.4",
-    "axe-core": "^4.1.2",
+    "axe-core": "^4.3.2",
     "babel-jest": "^26.6.3",
     "babel-loader": "^8.2.2",
     "core-js": "^3.9.1",

diff --git a/packages/components/src/Button/button.stories.tsx b/packages/components/src/Button/button.stories.tsx
@@ -83,13 +83,23 @@ linkWithIcon.args = {
   color: "success",
   variant: "link",
 };
+linkWithIcon.parameters = {
+  axe: {
+    disabledRules: ["aria-allowed-role"],
+  },
+};
 
 export const outlineWithIcon = Template.bind(null);
 outlineWithIcon.args = {
   children: <>Outline with icon {heartIcon}</>,
   color: "warning",
   variant: "outline",
 };
+outlineWithIcon.parameters = {
+  axe: {
+    disabledRules: ["aria-allowed-role"],
+  },
+};
 
 export const withFakeClassName = Template.bind(null);
 withFakeClassName.args = {

diff --git a/packages/components/src/SvgIcon/SvgIcon.stories.tsx b/packages/components/src/SvgIcon/SvgIcon.stories.tsx
@@ -41,6 +41,12 @@ export default {
       },
     },
   },
+
+  parameters: {
+    axe: {
+      disabledRules: ["aria-allowed-role"],
+    },
+  },
 };
 
 type Args = React.ComponentProps<typeof SvgIcon> & {
@@ -84,7 +90,7 @@ FullScreen.args = {
 
 FullScreen.parameters = {
   axe: {
-    disabledRules: ["scrollable-region-focusable"],
+    disabledRules: ["aria-allowed-role", "scrollable-region-focusable"],
   },
 };
 
@@ -150,7 +156,7 @@ AllIcons.parameters = {
     skip: true,
   },
   axe: {
-    disabledRules: ["scrollable-region-focusable"],
+    disabledRules: ["aria-allowed-role", "scrollable-region-focusable"],
   },
   controls: {
     hideNoControlsWarning: true,