Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Touch up of spatial release article #1345

Merged
merged 3 commits into from
Feb 3, 2025

Conversation

ivirshup
Copy link
Collaborator

@ivirshup ivirshup commented Jan 31, 2025

  • Added links to relevant tiledbsoma and spatialdata doc pages
  • Fixed outdated image documentation

This looks like:

image

Where the bolded code titles link to the tiledbsoma documentation.

  • .levels() is not currently documented, but was on the original set of attributes to document. I will check in with tiledb on this

@ivirshup ivirshup added documentation Improvements or additions to documentation spatial labels Jan 31, 2025
Copy link
Collaborator

@MaximilianLombardo MaximilianLombardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thinking we should specify the specific Slide Seq version?

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.42%. Comparing base (50fea93) to head (eb34026).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1345   +/-   ##
=======================================
  Coverage   91.42%   91.42%           
=======================================
  Files          82       82           
  Lines        6487     6487           
=======================================
  Hits         5931     5931           
  Misses        556      556           
Flag Coverage Δ
unittests 91.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ivirshup ivirshup merged commit 9b6d444 into main Feb 3, 2025
13 checks passed
@ivirshup ivirshup deleted the ivirshup/touchup-spatial-release-article branch February 3, 2025 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation spatial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants