Fix build break in TTD #4821
Merged
Fix build break in TTD #4821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent change removed an unused parameter from the Js::CallInfo constructor. TTD was still using this constructor in release/1.9 so the build broke after the change merged in.
|
LGTM - I did the same thing in the master branch. |
mike-kaufman
approved these changes
Mar 14, 2018
|
I'm going to force merge this to unblock the build. |
chakrabot
pushed a commit
that referenced
this pull request
Mar 14, 2018
chakrabot
pushed a commit
that referenced
this pull request
Mar 14, 2018
Merge pull request #4821 from kfarnung:buildfix A recent change removed an unused parameter from the Js::CallInfo constructor. TTD was still using this constructor in release/1.9 so the build broke after the change merged in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent change removed an unused parameter from the Js::CallInfo
constructor. TTD was still using this constructor in release/1.9 so the
build broke after the change merged in.