Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing missing serialization for new.target property in TTD #4685

Merged
merged 1 commit into from
Feb 15, 2018
Merged

Fixing missing serialization for new.target property in TTD #4685

merged 1 commit into from
Feb 15, 2018

Conversation

MSLaguana
Copy link
Contributor

No description provided.

@MSLaguana MSLaguana requested a review from mrkmarron February 14, 2018 23:46
digitalinfinity
digitalinfinity approved these changes Feb 14, 2018
View reviewed changes
Copy link
Contributor

@digitalinfinity digitalinfinity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a test we could add in ChakraCore itself?

@MSLaguana
Copy link
Contributor Author

I'll defer to @mrkmarron on whether we can write a test for this; I just tried creating some classes and referring to new.target in them, recording it and replaying the trace, but I think I was doing something wrong there and the replay never seemed to do anything.

@MSLaguana MSLaguana changed the base branch from master to release/1.9 February 15, 2018 00:03
@chakrabot chakrabot merged commit a091991 into chakra-core:release/1.9 Feb 15, 2018
chakrabot pushed a commit that referenced this pull request Feb 15, 2018
@MSLaguana
[MERGE #4685 @MSLaguana] Fixing missing serialization for new.target …
95875b5 
…property in TTD

Merge pull request #4685 from MSLaguana:fixNewTargetTTD
chakrabot pushed a commit that referenced this pull request Feb 15, 2018
@MSLaguana
[1.9>master] [MERGE #4685 @MSLaguana] Fixing missing serialization fo…
002e9be 
…r new.target property in TTD

Merge pull request #4685 from MSLaguana:fixNewTargetTTD
@MSLaguana MSLaguana deleted the fixNewTargetTTD branch February 15, 2018 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfarnung kfarnung kfarnung approved these changes

@digitalinfinity digitalinfinity digitalinfinity approved these changes

@mrkmarron mrkmarron Awaiting requested review from mrkmarron

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MSLaguana @digitalinfinity @kfarnung @chakrabot