replace wchar_t/L"..." with char16/_u("...") #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I took a sampling of the changed files. Looks great |
|
Reviewed 48 of 443 files at r1. lib/Runtime/Library/UriHelper.cpp, line 147 [r1] (raw file): Comments from the review on Reviewable.io |
|
I looked at a few files and it looks good. I assume this was more or less a find-and-replace operation and since it compiles, I'd say LGTM |
added 2 commits
March 7, 2016 15:53
wchar_t and L"..." use 2-byte chars on Windows but 4-byte chars on Unix.
We need a common representation for cross-platform.
C++11 has native char16_t and u"..." support. But unfortunately that's
not supported by VS 2013.
This change prepares the code to use char16 and _u("...").
Replace wchar_t/L"..." with char16/_u("...") in all sources (except public
JSRT APIs. Will revisit later.)
|
Thanks guys! Will merge this. |
chakrabot
pushed a commit
that referenced
this pull request
Mar 8, 2016
Merge pull request #460 from jianchun:wchar Replace wchar_t/L"..." with char16/_u("...") in all sources (except public JSRT APIs. Will revisit later.) <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/microsoft/chakracore/460) <!-- Reviewable:end -->
jianchun
pushed a commit
to jianchun/ChakraCore
that referenced
this pull request
Mar 8, 2016
Missed a pattern of L'...' literal in previous batch replacement chakra-core#460. Remove unused code in Throw.h/cpp
jianchun
pushed a commit
to jianchun/ChakraCore
that referenced
this pull request
Mar 8, 2016
Missed a pattern of L'...' literal in previous batch replacement chakra-core#460. Remove unused code in Throw.h/cpp
chakrabot
pushed a commit
that referenced
this pull request
Mar 8, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace wchar_t/L"..." with char16/_u("...") in all sources (except public
JSRT APIs. Will revisit later.)