[1.8>1.9] [MERGE #4610 @agarwal-sandeep] OS#15522456 ScriptContext cr…

…eated after calling JsDiagStopDebugging should set debugging mode as SourceRunDown instead of Debugging.

Merge pull request #4610 from agarwal-sandeep:fixstopdebuggingbug

Found by OSS-Fuzz.

lib/Jsrt/Jsrt.cpp

@@ -178,17 +178,27 @@ JsErrorCode CreateContextCore(_In_ JsRuntimeHandle runtimeHandle, _In_ TTDRecord
 
     if(jsrtDebugManager != nullptr)
     {
+        // JsDiagStartDebugging was called
+        threadContext->GetDebugManager()->SetLocalsDisplayFlags(Js::DebugManager::LocalsDisplayFlags::LocalsDisplayFlags_NoGroupMethods);
+
         Js::ScriptContext* scriptContext = context->GetScriptContext();
-        scriptContext->InitializeDebugging();
 
         Js::DebugContext* debugContext = scriptContext->GetDebugContext();
         debugContext->SetHostDebugContext(jsrtDebugManager);
 
-        Js::ProbeContainer* probeContainer = debugContext->GetProbeContainer();
-        probeContainer->InitializeInlineBreakEngine(jsrtDebugManager);
-        probeContainer->InitializeDebuggerScriptOptionCallback(jsrtDebugManager);
-
-        threadContext->GetDebugManager()->SetLocalsDisplayFlags(Js::DebugManager::LocalsDisplayFlags::LocalsDisplayFlags_NoGroupMethods);
+        if (!jsrtDebugManager->IsDebugEventCallbackSet())
+        {
+            // JsDiagStopDebugging was called so we need to be in SourceRunDownMode
+            debugContext->SetDebuggerMode(Js::DebuggerMode::SourceRundown);
+        }
+        else
+        {
+            // Set Debugging mode
+            scriptContext->InitializeDebugging();
+            Js::ProbeContainer* probeContainer = debugContext->GetProbeContainer();
+            probeContainer->InitializeInlineBreakEngine(jsrtDebugManager);
+            probeContainer->InitializeDebuggerScriptOptionCallback(jsrtDebugManager);
+        }
     }
 #endif
 

lib/Jsrt/JsrtDiag.cpp

@@ -99,9 +99,13 @@ CHAKRA_API JsDiagStartDebugging(
                 return JsErrorFatal;
             }
 
-            Js::ProbeContainer* probeContainer = debugContext->GetProbeContainer();
-            probeContainer->InitializeInlineBreakEngine(jsrtDebugManager);
-            probeContainer->InitializeDebuggerScriptOptionCallback(jsrtDebugManager);
+            // ScriptContext might get closed in OnDebuggerAttached
+            if (!scriptContext->IsClosed())
+            {
+                Js::ProbeContainer* probeContainer = debugContext->GetProbeContainer();
+                probeContainer->InitializeInlineBreakEngine(jsrtDebugManager);
+                probeContainer->InitializeDebuggerScriptOptionCallback(jsrtDebugManager);
+            }
         }
 
         return JsNoError;

test/Debugger/emptyJson.dbg.baseline

@@ -0,0 +1 @@
+[]

test/Debugger/loadscript_after_detach.js

@@ -0,0 +1,17 @@
+//-------------------------------------------------------------------------------------------------------
+// Copyright (C) Microsoft. All rights reserved.
+// Licensed under the MIT license. See LICENSE.txt file in the project root for full license information.
+//-------------------------------------------------------------------------------------------------------
+
+var count = 0;
+function foo() {
+  count++;
+  if (count == 3) {
+    WScript.LoadScript("", "samethread"); // ScriptContext should be created in sourcerundown mode instead of debugging mode
+  }
+}
+foo();
+WScript.Attach(foo);
+WScript.Detach(foo);
+WScript.Attach(foo);
+WScript.Echo("pass");

test/Debugger/rlexe.xml

@@ -80,4 +80,10 @@
       <files>dumpFunctionProperties.js</files>
     </default>
   </test>
+  <test>
+    <default>
+      <compile-flags>-dbgbaseline:emptyJson.dbg.baseline</compile-flags>
+      <files>loadscript_after_detach.js</files>
+    </default>
+  </test>
 </regress-exe>