[1.9>master] [1.8>1.9] [MERGE #4631 @digitalinfinity] OS 15681335: Fi…

…x inspection of Promise state in debugger Merge pull request #4631 from digitalinfinity:os_15681335_1.8 RecyclablePromiseObjectWalker::Get had a missing break when inspecting the state of a promise, causing an unresolved promise to show up as resolved in F12. Fixed the logic here.
chakra-core · Feb 1, 2018 · 3f1052f · 3f1052f
2 parents d8c169f + 8c0764e
commit 3f1052f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/lib/Runtime/Debug/DiagObjectModel.cpp b/lib/Runtime/Debug/DiagObjectModel.cpp
@@ -3896,6 +3896,7 @@ namespace Js
                 break;
             case JavascriptPromise::PromiseStatusCode_Unresolved:
                 pResolvedObject->obj = scriptContext->GetLibrary()->CreateStringFromCppLiteral(_u("pending"));
+                break;
             case JavascriptPromise::PromiseStatusCode_HasResolution:
                 pResolvedObject->obj = scriptContext->GetLibrary()->CreateStringFromCppLiteral(_u("resolved"));
                 break;

diff --git a/test/DebuggerCommon/promiseDisplay.js.dbg.baseline b/test/DebuggerCommon/promiseDisplay.js.dbg.baseline
@@ -11,7 +11,7 @@
         },
         "someOtherProp": "string before",
         "[Promise]": {
-          "[status]": "string resolved",
+          "[status]": "string pending",
           "[value]": "string undefined"
         }
       }