Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security fix5 connection rate #317

Merged
merged 3 commits into from
Nov 8, 2024

Conversation

Naviabheeman
Copy link
Contributor

port security fix for Disclosure of remote crash due to addr message spam from PR #22387 - Rate limit the processing of rumoured addresses
Tapyrus does not differentiate inbound and outbound peers. So rate limiting is applied to all peers.

  • This PR depends on Security fix 4 - Simplify node time and network-adjusted time warning logic #315 for 'gettime' related changes.
  • 'rescanning_old_block' is a new parameter in ComputeTimeSmart (ported from bitcoin). IT is obtained from the block index. Without this timestamp the rate of transactions does not get computed correctly.
  • test framework is changed to support the scenarios needed in 'addr' message tests.
  • 'p2p_addr_relay' test case is ported from bitcoin. It does not contain the 'getaddr' scenarios and v2 adds tests not available in Tapyrus
  • 'p2p_invalid_messages' is not ported as it does not contain any relevant test case for the changes in this PR. We can port the test case later on as a general test of invalid p2p messages.

@Naviabheeman Naviabheeman force-pushed the SecurityFix5_connection_rate branch from efe79bf to cf7b48a Compare November 5, 2024 07:31
@azuchi azuchi merged commit 29b95a8 into chaintope:master Nov 8, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants