Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix lint warnings #18

Merged
merged 6 commits into from
Aug 10, 2022
Merged

fix lint warnings #18

merged 6 commits into from
Aug 10, 2022

Conversation

k4leung4
Copy link
Contributor 

Error: pkg/options/options.go:37:35: G404: Use of weak random number generator (math/rand instead of crypto/rand) (gosec)
		scheme := fmt.Sprintf("test%d", rand.Uint64())

Error: pkg/duplex/server.go:74:34: SA1019: grpc.WithInsecure is deprecated: use WithTransportCredentials and insecure.NewCredentials() instead. Will be supported throughout 1.x. (staticcheck)
		DialOptions: []grpc.DialOption{grpc.WithInsecure()},

Signed-off-by: Kenny Leung kleung@chainguard.dev

@k4leung4
fix lint warnings
3f30c24 
Signed-off-by: Kenny Leung <kleung@chainguard.dev>
@k4leung4 k4leung4 requested review from tcnghia, mattmoor and cpanato and removed request for tcnghia, mattmoor and cpanato August 10, 2022 18:03
@k4leung4 k4leung4 marked this pull request as draft August 10, 2022 18:05
@k4leung4
use math/rand
09b6cee 
Signed-off-by: Kenny Leung <kleung@chainguard.dev>
@k4leung4
add deps
79f2dce 
Signed-off-by: Kenny Leung <kleung@chainguard.dev>
@k4leung4
crypto/rand
686f8a8 
Signed-off-by: Kenny Leung <kleung@chainguard.dev>
@k4leung4
panic on rand
302e12c 
Signed-off-by: Kenny Leung <kleung@chainguard.dev>
@k4leung4
gofmt
6b2aae6 
Signed-off-by: Kenny Leung <kleung@chainguard.dev>
@k4leung4 k4leung4 requested review from mattmoor and tcnghia August 10, 2022 18:41
@k4leung4 k4leung4 marked this pull request as ready for review August 10, 2022 18:41
@k4leung4 k4leung4 merged commit 60fdc0f into chainguard-dev:main Aug 10, 2022
@k4leung4 k4leung4 deleted the fix-lint branch August 10, 2022 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmoor mattmoor mattmoor approved these changes

@tcnghia tcnghia Awaiting requested review from tcnghia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k4leung4 @mattmoor