Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider optimising the happy path in broadcast verification #1114

Closed
msgmaxim opened this issue Jan 5, 2022 · 1 comment
Closed

Consider optimising the happy path in broadcast verification #1114

msgmaxim opened this issue Jan 5, 2022 · 1 comment
Labels
CFE effort-3 Will need to plan this before implementing p4-somedaymaybe refactor

Comments

@msgmaxim
Copy link
Contributor

msgmaxim commented Jan 5, 2022

As demonstrated in #966, keygen ceremonies require sending/recieving on the order of 100MB of data in some stages. This has caused some buffer overflowing before and is likely lead to nodes timing out more often leading to more frequent ceremony failures. While buffer overflow should be fixed in #1104 by batching broadcast messages (between CFE and SC), it won't reduce the total amount of data to be sent/received over the internet.

One way to reduce the bandwidth usage is to "compress" the data by hashing it during the broadcast verification stage. If all nodes are honest and send the same data, all participants will be able to verify the broadcast by simply comparing the hashes. The downside is that we will need to add additional logic to handle the (presumably rare) cases where some hashes don't match.

I was assured that bandwidth has not really been an issue (at least on testnet), so giving this a low priority as #1104 will fix the one issue we had on testnet (buffer overflow).

@nakul-cf nakul-cf changed the title Consider optimising the happy path in broadcast verification [SC-2885] Consider optimising the happy path in broadcast verification Jan 5, 2022
@morelazers morelazers added p2-somedaysoon refactor effort-3 Will need to plan this before implementing and removed p4-somedaymaybe labels Mar 14, 2022
@morelazers
Copy link

@msgmaxim upping the priority of this one since I think it will be a big benefit to our efforts in scaling the set sizes.

I do think that the highest priority item is just to make the p2p connections reliable however, and we should make a concerted effort to do that with libp2p for one iteration, and then if we can't make progress on that front we should ditch libp2p entirely.

@morelazers morelazers changed the title [SC-2885] Consider optimising the happy path in broadcast verification Consider optimising the happy path in broadcast verification May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CFE effort-3 Will need to plan this before implementing p4-somedaymaybe refactor
Projects
None yet
Development

No branches or pull requests

4 participants