You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently the multisig outputs the messages it would like to send via p2p on a channel where each message is sent as a separate pair of account id and message. I would like to refactor this so that all the messages to be sent in a single stage as grouped into a single struct/item sent on the channel. This would allow us to remove the duplicate of the sent message in the broadcast case. And make the multisig tests significantly simpler, as waiting for all the messages from a completed stage, is a single wait (and the number of waits isn't dependent on the number of participants). Also it would help avoid repeatedly encoding the message before sending it.
TODO More detail.
Describe the solution you'd like to implement
A more thorough technical description of the code to be introduced. Including but not limited to:
Dependencies
New dependencies
Dependencies assumed of other components
Suspected (or actual, if possible) breaking changes
Target Branch
Linked Issues (Either Github or Shortcut)
Storage
Types
Public variables
Additions to config
Deletions
Functions (private functions not necessary)
Statics with signatures
Methods with signatures
Interfaces / Apis exposed to other components to interact with
Doc block
Deletions
Test cases / invariants / edge cases
Events
Signatures
"Topics"
Emission conditions (pseudocode or english)
Deletions
Shortcut Story Link
[SC-XXXX].
Describe alternatives you've considered
A clear and concise description of any alternative solutions you've considered.
Additional context
Add any other context or screenshots about the request here. E.g. Swimlanes.
Currently the multisig outputs the messages it would like to send via p2p on a channel where each message is sent as a separate pair of account id and message. I would like to refactor this so that all the messages to be sent in a single stage as grouped into a single struct/item sent on the channel. This would allow us to remove the duplicate of the sent message in the broadcast case. And make the multisig tests significantly simpler, as waiting for all the messages from a completed stage, is a single wait (and the number of waits isn't dependent on the number of participants). Also it would help avoid repeatedly encoding the message before sending it.
TODO More detail.
Describe the solution you'd like to implement
A more thorough technical description of the code to be introduced. Including but not limited to:
Dependencies
Storage
Functions (private functions not necessary)
Events
Shortcut Story Link
[SC-XXXX].
Describe alternatives you've considered
A clear and concise description of any alternative solutions you've considered.
Additional context
Add any other context or screenshots about the request here. E.g. Swimlanes.
Tag specific people for comment
@msgmaxim
The text was updated successfully, but these errors were encountered: