Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SC-2880] Batch P2P Messages for a single multisig stage #1104

Closed
AlastairHolmes opened this issue Jan 3, 2022 · 2 comments · Fixed by #1149
Closed

[SC-2880] Batch P2P Messages for a single multisig stage #1104

AlastairHolmes opened this issue Jan 3, 2022 · 2 comments · Fixed by #1149
Assignees

Comments

@AlastairHolmes
Copy link
Contributor

Currently the multisig outputs the messages it would like to send via p2p on a channel where each message is sent as a separate pair of account id and message. I would like to refactor this so that all the messages to be sent in a single stage as grouped into a single struct/item sent on the channel. This would allow us to remove the duplicate of the sent message in the broadcast case. And make the multisig tests significantly simpler, as waiting for all the messages from a completed stage, is a single wait (and the number of waits isn't dependent on the number of participants). Also it would help avoid repeatedly encoding the message before sending it.

TODO More detail.

Describe the solution you'd like to implement

A more thorough technical description of the code to be introduced. Including but not limited to:

Dependencies

  • New dependencies
  • Dependencies assumed of other components
  • Suspected (or actual, if possible) breaking changes
  • Target Branch
  • Linked Issues (Either Github or Shortcut)

Storage

  • Types
  • Public variables
  • Additions to config
  • Deletions

Functions (private functions not necessary)

  • Statics with signatures
  • Methods with signatures
  • Interfaces / Apis exposed to other components to interact with
  • Doc block
  • Deletions
  • Test cases / invariants / edge cases

Events

  • Signatures
  • "Topics"
  • Emission conditions (pseudocode or english)
  • Deletions

Shortcut Story Link

[SC-XXXX].

Describe alternatives you've considered

A clear and concise description of any alternative solutions you've considered.

Additional context

Add any other context or screenshots about the request here. E.g. Swimlanes.

Tag specific people for comment

@msgmaxim

@AlastairHolmes AlastairHolmes self-assigned this Jan 3, 2022
@AlastairHolmes
Copy link
Contributor Author

#966

@nakul-cf nakul-cf changed the title Batch P2P Messages for a single multisig stage [SC-2880] Batch P2P Messages for a single multisig stage Jan 5, 2022
@AlastairHolmes
Copy link
Contributor Author

Going to wait for @msgmaxim 's unit test PR before implementing this.

@kylezs kylezs linked a pull request Jan 11, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant