[PVM] Add kyb verified state, allow kyb verified to propose add member #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
098b9dc to
ac55cf6
Compare
havan
previously approved these changes
Jul 24, 2024
0f7232a to
89b58eb
Compare
ac55cf6 to
c71e284
Compare
mo-c4t
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This PR adds AddressStateKYBVerified, its bit 34.
AddressStateKYBVerified bit can be set by AddressStateRoleKYCAdmin.
This bit allows to create addMemberProposals.
How this works
AddressStateKYBVerified is added to BerlinPhase bits set, so its treated as valid bit starting from BerlinPhase.
PR adds corresponding test cases for AddressStateTx and for addMemberProposal.
How this was tested
By existing unit tests.
Additional references
Original PR based on cortina-19 dev
#340