[PVM] Fix CaminoRewardValidatorTx onAbort address state #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
66044cf to
aa7dd22
Compare
havan
previously approved these changes
Jul 24, 2024
mo-c4t
previously approved these changes
Jul 24, 2024
The base branch was changed.
mo-c4t
approved these changes
Jul 25, 2024
evlekht
added a commit
that referenced
this pull request
Aug 1, 2024
(cherry picked from commit 0fe6350)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
CaminoRewardValidatorTx execution has error, most likely copy-paste mistake. It expected, that onCommit and onAbort states will be identical, but tx is not setting deferred addressState bit in onAbort state and setting it twice in onCommit state.
How this works
This looks like a simple copy-paste error. So PR simply replaces onCommit state with onAbort state.
How this was tested
It wasn't.
Additional references
Original PR based on cortina-19 dev
#322