Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change edge running animation + behavior #2424

Merged
merged 9 commits into from
Jan 5, 2024
Merged

Change edge running animation + behavior #2424

merged 9 commits into from
Jan 5, 2024

Conversation

joeyballentine
Copy link
Member

This changes a few things:

  • The running edge animation is now just a standard crawling ants animation, but with rounded caps and a solid gray edge behind it. Ideally IMO it would be kinda like a loading animation instead but I'm not sure that's possible.
  • Edges will now only be animated when the source node is running. To accomplish this, I had to change when the node start event gets sent out. Now, it sends that out after all the inputs are computed. Honestly, this just makes more sense in general, since the node really isn't running until after its inputs are done.
  • Yet-to-run edges are now 50% opacity white.

With this, I think it's a bit more obvious what's actually in the process of running. Ideally, this also should reduce CPU usage due to the fewer animations, but I haven't actually checked that.

@joeyballentine
Copy link
Member Author

I originally submitted this with an error. It is now fixed.

@akx
Copy link

akx commented Jan 2, 2024

Ideally IMO it would be kinda like a loading animation instead but I'm not sure that's possible.

If you're OK with losing rounded corners, you can do a loading animation sort of thing with conic gradients... https://snz5t2.csb.app/

@joeyballentine
Copy link
Member Author

joeyballentine commented Jan 2, 2024

That's certainly an interesting idea and definitely worth trying out, thanks for the suggestion

@joeyballentine
Copy link
Member Author

After thinking about it a bit more, i don't think i'll be able to do that, since the direction that any edge could be going in is arbitrary, i don't think you could adapt a conical gradient to work in every scenario

Co-authored-by: Michael Schmidt <mitchi5000.ms@googlemail.com>
@joeyballentine joeyballentine merged commit 3512e37 into main Jan 5, 2024
17 checks passed
@joeyballentine joeyballentine deleted the edge-changes branch January 5, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants