Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to spandrel 0.1.5 and enforce model tiling hint #2412

Merged
merged 2 commits into from
Dec 17, 2023
Merged

Update to spandrel 0.1.5 and enforce model tiling hint #2412

merged 2 commits into from
Dec 17, 2023

Conversation

RunDevelopment
Copy link
Member

Changes:

  • Update to spandrel 0.1.5.
  • Always use no tiling mode if the model does tiling internally no matter what the user selects.

@joeyballentine
Copy link
Member

Would we be able to hide the tiling option when a model doesn't support it?

@RunDevelopment
Copy link
Member Author

It's possible, but it also means that the tile size dropdown won't appear until the user connects a model.
image

@RunDevelopment
Copy link
Member Author

Oh, my bad. I already added an option to solve this problem before.
image

@joeyballentine joeyballentine merged commit ca8fca8 into chaiNNer-org:main Dec 17, 2023
17 checks passed
@RunDevelopment RunDevelopment deleted the spandrel-0.1.5 branch December 17, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeyballentine joeyballentine joeyballentine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RunDevelopment @joeyballentine