Remove GPU list endpoints #2333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed we still had these around. The NCNN one wasn't being used by anything, and the nvidia one is being used for something on the frontend that basically just tells you if you have an nvidia gpu or not.
The frontend shouldn't care about that (imo). CUDA is only relevant to the pytorch and onnx dependencies, and they already handle changing their deps based on whether the GPU is supported or not.
If we were to do something to show that, i would think we'd do something like the feature system, where we'd have a "CUDA" feature that displays that it is enabled somewhere. idk, i don't really think its that important.