Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that our box blur was slower than gauss for large radii, so I know that something was wrong. We were using a
cv2.filter2D
based box blur. While this is correct, it's not ideal for performance. Box blur is a highly optimizable filter, socv2.filter2D
is far too general.I used
cv2.blur
(which implements a highly optimized box blur) whenever possible. Sincecv2.blur
only supports integer radii, I only use it when the radii are integers and when the radii are so large that the difference between N.5 and N is not noticeable.With my 2k example image, the box blur node takes this long: