Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Remove Background types #2291

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

RunDevelopment
Copy link
Member

Changes:

  • I inlined the removeBackground function because it was only used in one place.
  • The main image output now guarantees an RGBA image. This wasn't enforced at runtime before.
  • The image input now requires an RGB or RGBA image. Grayscale images are invalid inputs and cause a crash.

Open question: Should the image input accept RGBA images in the first place? RGBA images will be converted to RGB internally, so the alpha channel is completely ignored.

@joeyballentine joeyballentine merged commit 8e8be5d into chaiNNer-org:main Oct 30, 2023
@RunDevelopment RunDevelopment deleted the rembg-types branch October 30, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants