Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed iterator helper node type persistence #1222

Merged
merged 3 commits into from
Nov 12, 2022

Conversation

RunDevelopment
Copy link
Member

Fixes #838.

The manual output types for iterator helper nodes caused problems because they can be out-of-date easily. Since these nodes do not have any inputs, their input hash never changes and so the manual output type is never reset.

This PR fixes this issue in 2 ways:

  1. Iterator helper nodes with an "Auto (Iterator)" will now "inherit" the input hash of the parent iterator. This causes their input hash to change whenever the parent iterator changes.
  2. useOutputData now explicitly return the last and current output. This difference makes it impossible to accidentally display/have types of old output data.

@joeyballentine joeyballentine merged commit 8640760 into chaiNNer-org:main Nov 12, 2022
@RunDevelopment RunDevelopment deleted the issue838 branch November 12, 2022 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Iterator broadcast persistence can break Fill Alpha
2 participants