Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only ignore DEBUG conditional compilation #855

Closed
wants to merge 4 commits into from
Closed

Conversation

cgrindel
Copy link
Owner

@cgrindel cgrindel commented Jan 15, 2024

When evaluating whether a source file has a certain import, we will only ignore imports in conditional compilation blocks if it is keying off of DEBUG.

  • Add RxSwift to the ios_sim example.
  • Update swift_files.has_import() to only ignore code in a conditional compilation block if the evaluator is DEBUG.

Closes #791.

@cgrindel cgrindel self-assigned this Jan 15, 2024
@cgrindel cgrindel requested review from jpsim and luispadron January 15, 2024 19:18
@cgrindel cgrindel marked this pull request as ready for review January 15, 2024 19:18
@jpsim
Copy link
Collaborator

jpsim commented Jan 17, 2024

Thanks for looking into this!

However I think this is incorrectly marking https://github.com/pointfreeco/swift-dependencies as testonly.

@cgrindel
Copy link
Owner Author

However I think this is incorrectly marking https://github.com/pointfreeco/swift-dependencies as testonly.

@jpsim Do you know which target?

@cgrindel
Copy link
Owner Author

Do you know which target?\

Nevermind. Found it.

@cgrindel cgrindel marked this pull request as draft January 20, 2024 15:54
@cgrindel
Copy link
Owner Author

Instead of trying to configure targets based upon their import of XCTest, we are going to use always_include_developer_search_paths once this PR is merged.

@cgrindel cgrindel closed this Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The RxTest module for ReactiveX/RxSwift does not compile.
2 participants