Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move title display / mobile hide logic into template #14

Closed
guywillis opened this issue Jul 4, 2024 · 1 comment · Fixed by #15
Closed

Move title display / mobile hide logic into template #14

guywillis opened this issue Jul 4, 2024 · 1 comment · Fixed by #15
Assignees
@guywillis
Labels
bug released

Comments

@guywillis
Copy link
Contributor

Subject of the issue

The logic for displaying which title and for showing / hiding the title in mobile view could probably be moved into the template rather than being done in the JS.

Your environment

  • Master FW & AT
@guywillis guywillis added the bug label Jul 4, 2024
@guywillis guywillis self-assigned this Jul 4, 2024
@guywillis guywillis mentioned this issue Jul 4, 2024
Merged
github-actions bot pushed a commit that referenced this issue Jul 15, 2024
@semantic-release-bot
Chore(release): 1.0.4 [skip ci]
5ec4c50 
## [1.0.4](v1.0.3...v1.0.4) (2024-07-15)

### Fix

* Moved JS logic into template jsx (fixes #14) ([e60fc64](e60fc64)), closes [#14](#14)
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 1.0.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guywillis guywillis

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Moved JS logic into template jsx (fixes #14) cgkineo/adapt-navigationTitle
1 participant
@guywillis