Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Readyness for v1 AAT (fixes: #18) #20

Merged
merged 5 commits into from
Feb 10, 2023
Merged

Fix: Readyness for v1 AAT (fixes: #18) #20

merged 5 commits into from
Feb 10, 2023

Conversation

joe-replin
Copy link
Contributor

Fix

Testing

  1. Add to v1 AAT and test settings.

@joe-replin joe-replin self-assigned this Jan 20, 2023
@joe-replin joe-replin linked an issue Jan 20, 2023 that may be closed by this pull request
Add support for authoring tool 1 #18
Closed
@swashbuck
Copy link
Contributor

"Redirect the home button to id"
This could use help tooltip explaining that the Friendly ID should be used. Maybe mention redirecting to a splash page is a common use case?

Otherwise, looks good.

@swashbuck swashbuck self-requested a review February 3, 2023 19:40
swashbuck
swashbuck approved these changes Feb 10, 2023
View reviewed changes
Copy link
Contributor

@swashbuck swashbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@swashbuck swashbuck merged commit 6b65200 into master Feb 10, 2023
@swashbuck swashbuck deleted the issue/18 branch February 10, 2023 22:37
@github-actions
Copy link

🎉 This PR is included in version 1.0.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swashbuck swashbuck swashbuck approved these changes

Assignees

@joe-replin joe-replin

Labels
enhancement released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for authoring tool 1
2 participants
@joe-replin @swashbuck