-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support hardhat #34
Comments
Hey Chris! Lot's of new things are coming out with hardhat. We'll have a migration guide for plugins in a few days. We also took some time to adapt solidity-coverage. We'll send a PR soon. We are just finishing some details on how plugins are managed. Hardhat will be closer to the og version of Buidler, were plugins were just imported/required. This means that users won't need to deal with the type extensions manually. |
@alcuadrado Ok fantastic, thanks so much. 🙂 |
Hey @cgewecke, we have a migration guide for plugins now: https://github.com/nomiclabs/buidler-ts-plugin-boilerplate/blob/hardhat-migration/MIGRATION.md There are |
Do you think it might make sense to make a new repo called |
We are planning to rename the repos and leave a 1-line message explaining about the migration in the readme. |
@cgewecke @alcuadrado |
@mudgen Will look at it this weekend. Should be simple here... |
hola! any news on the support for hardhat? thanks! |
@jmonteer Doing it today!! Swear. |
@cgewecke You are the man! |
@cgewecke How is it going? I am curious. Is it easy or hard to port a buidler plugin to hardhat? |
Really sorry - this is slightly trickier than I thought - I might have to modify the way eth-gas-reporter processes artifacts and publish a new version over there as well. Am working on this today and will get it out... |
Let me know if you need help with this, Chris! |
@alcuadrado Thanks Patricio! |
@mudgen There's a beta published now if you need this ASAP.
If there are contracts that Hardhat needs a path-qualified name to load the artifact of, they'll be missing from the report. This should only happen if the contract name is duplicated somewhere in the project (like in a node_modules dependency) or you're staging multiple versions of the same contracts in your project (like |
@cgewecke Great. Thank you. |
This is out as hardhat-gas-reporter@1.0.0 Please just lmk if you run into problems with it. One thing that jumped out in e2e testing is that projects with qualified contract names have wide reports. (Perhaps over-wide, really) Addressing that in a forth-coming patch at eth-gas-reporter and tracking the issue here in #40. |
A list of known issues:
Update: a beta is available
(It may be missing some data if your project contains shadowed contract names. See more below)
The text was updated successfully, but these errors were encountered: