This repository has been archived by the owner on Mar 17, 2024. It is now read-only.
Update Mocha to v10 #295
Merged
Update Mocha to v10 #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgewecke
approved these changes
Sep 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple bump in the package.json
I was not able to run the tests locally.
I had a look at Mocha's changelog, the only thing that looked like it might affect this project was dropped support for Node 12, so I bumped the version used in CI to 18. (Node 16 will reach end-of-life very soon.)
I checked in the console that the Base reporter is still there where eth-gas-reporter expects it.