Fix: Clarify the behavior of concurrent requests in QueuedInterceptor #2347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous documentation for `QueuedInterceptor` could lead to misunderstandings about how concurrent requests are handled. The explanation suggested that requests would have to wait for the previous request to complete before being initiated. This update clarifies that requests are processed in three independent queues: `onRequest`, `onResponse`, and `onError`. These queues run in parallel. Signed-off-by: 友人A <58846244+Passer-by@users.noreply.github.com>
Code Coverage Report: Only Changed Files listed
Minimum allowed coverage is |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
AlexV525
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous documentation for
QueuedInterceptorcould lead to misunderstandings about how concurrent requests are handled. The explanation suggested that requests would have to wait for the previous request to complete before being initiated.This update clarifies that requests are processed in three independent queues:
onRequest,onResponse, andonError. These queues run in parallel.New Pull Request Checklist
mainbranch to avoid conflicts (via merge from master or rebase)CHANGELOG.mdin the corresponding packageAdditional context and info (if any)