-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚡️ Split web_adapter
#2223
⚡️ Split web_adapter
#2223
Conversation
14397e4
to
3d7df45
Compare
For new plugin, publish action must be modified after the new plugin is released. |
All greened tests can be found at https://github.com/cfug/dio/actions/runs/9360866963/job/25766895250?pr=2223 I'm going to reset it for the first publishing. |
Coverage is working now, awesome! |
Nvm. |
Code Coverage Report: Only Changed Files listed
Minimum allowed coverage is |
Anyone want to stamp this? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think the CHANGELOG of dio should be added too, I'll commit it later |
@@ -3,6 +3,7 @@ import 'dart:async'; | |||
import 'adapter.dart'; | |||
import 'cancel_token.dart'; | |||
import 'dio/dio_for_native.dart' | |||
if (dart.library.js_interop) 'dio/dio_for_browser.dart' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AlexV525 I think we need to remove this import line everywhere. It now imports the old version specifically for WASM. I don't fully understand, why it was compiling with WASM before this was added.
After we actually add WASM support, we can add it back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is the reason, it could be additional compile checks are applied when the library is actually getting imported.
Breaks the web business into a separate package to prepare for further changes regarding the WASM builds.
New Pull Request Checklist
main
branch to avoid conflicts (via merge from master or rebase)CHANGELOG.md
in the corresponding packageAdditional context and info (if any)
Here we put a v1 for the package. Once it works, we will migrate to the js_interop and
package:web
implementation and publish v2.