Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coverage baseline generation #2221

Merged
merged 1 commit into from
May 19, 2024
Merged

Conversation

kuhnroyal
Copy link
Member

This should fix the baseline coverage generation. It now performs the exact same tests that the normal flow does.
It seems melos tasks can fail silently, in this case when the package filter is empty.

New Pull Request Checklist

  • I have read the Documentation
  • I have searched for a similar pull request in the project and found none
  • I have updated this branch with the latest main branch to avoid conflicts (via merge from master or rebase)
  • I have added the required tests to prove the fix/feature I'm adding
  • I have updated the documentation (if necessary)
  • I have run the tests without failures
  • I have updated the CHANGELOG.md in the corresponding package

Additional context and info (if any)

@kuhnroyal kuhnroyal self-assigned this May 19, 2024
@kuhnroyal kuhnroyal requested a review from a team as a code owner May 19, 2024 00:39
@kuhnroyal kuhnroyal mentioned this pull request May 19, 2024
7 tasks
Copy link
Contributor

Code Coverage Report

Package Base Coverage New Coverage Difference
dio 🔴 0% 🟢 81.41% 🟢 81.41%
Overall Coverage 🟠 0% 🟢 81.41% 🟢 81.41%

Minimum allowed coverage is 0%, this run produced 81.41%

@ueman ueman merged commit d2a632f into cfug:main May 19, 2024
3 checks passed
@kuhnroyal kuhnroyal deleted the fix/coverage-baseline branch May 19, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants