-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔥 Do not detaches sockets / terminates client stream #2173
Conversation
I've failed to write tests for these changes. I've tried using regular implementation and also Mockito, the |
I'm probably running into the state that some contents are using the main ref. The test works well locally. |
Looks reasonable, we should find a reproducible test case before we merge this imo. |
I'd appreciate any ideas. I still cannot find a solid case unless we can make some integration tests. |
7e0a8d5
to
537832e
Compare
Code Coverage Report
Minimum allowed coverage is |
Fixes #2170
New Pull Request Checklist
main
branch to avoid conflicts (via merge from master or rebase)CHANGELOG.md
in the corresponding package