Revert "Add constructor for DioExceptionType.badCertificate"

This reverts commit 930d6c6.
cfug · Apr 19, 2024 · 57e0678 · 57e0678
1 parent fde97b1
commit 57e0678
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 17 deletions.
diff --git a/dio/CHANGELOG.md b/dio/CHANGELOG.md
@@ -6,7 +6,6 @@ See the [Migration Guide][] for the complete breaking changes list.**
 ## Unreleased
 
 - Raise the min Dart SDK version to 2.18.0.
-- Add constructor for `DioExceptionType.badCertificate`.
 
 ## 5.4.3+1
 

diff --git a/dio/lib/src/adapters/io_adapter.dart b/dio/lib/src/adapters/io_adapter.dart
@@ -189,9 +189,11 @@ class IOHttpClientAdapter implements HttpClientAdapter {
         port,
       );
       if (!isCertApproved) {
-        throw DioException.badCertificate(
+        throw DioException(
           requestOptions: options,
+          type: DioExceptionType.badCertificate,
           error: responseStream.certificate,
+          message: 'The certificate of the response is not approved.',
         );
       }
     }

diff --git a/dio/lib/src/dio_exception.dart b/dio/lib/src/dio_exception.dart
@@ -18,7 +18,7 @@ enum DioExceptionType {
   /// It occurs when url is sent timeout.
   sendTimeout,
 
-  /// It occurs when receiving timeout.
+  ///It occurs when receiving timeout.
   receiveTimeout,
 
   /// Caused by an incorrect certificate as configured by [ValidateCertificate].
@@ -142,18 +142,6 @@ class DioException implements Exception {
         error: error,
       );
 
-  factory DioException.badCertificate({
-    required RequestOptions requestOptions,
-    Object? error,
-  }) =>
-      DioException(
-        type: DioExceptionType.badCertificate,
-        message: 'The certificate of the response is not approved.',
-        requestOptions: requestOptions,
-        response: null,
-        error: error,
-      );
-
   factory DioException.requestCancelled({
     required RequestOptions requestOptions,
     required Object? reason,

diff --git a/dio/lib/src/interceptors/log.dart b/dio/lib/src/interceptors/log.dart
@@ -51,13 +51,13 @@ class LogInterceptor extends Interceptor {
   /// Log printer; defaults print log to console.
   /// In flutter, you'd better use debugPrint.
   /// you can also write log in a file, for example:
-  /// ```dart
+  ///```dart
   ///  final file=File("./log.txt");
   ///  final sink=file.openWrite();
   ///  dio.interceptors.add(LogInterceptor(logPrint: sink.writeln));
   ///  ...
   ///  await sink.close();
-  /// ```
+  ///```
   void Function(Object object) logPrint;
 
   @override