Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Regtech Regex Support to Node Environments #22

Merged
merged 8 commits into from
Dec 19, 2024

Conversation

tanner-ricks
Copy link
Contributor

@tanner-ricks tanner-ricks commented Dec 12, 2024

Added yaml to json conversation of the regexs as well as node import support

Changes

  • Added yarn build logic to convert the yaml file to json
  • Added supporting configuration and logic to give node projects access to the imports
  • Added documentation to the best of my knowledge

Checklist

  • If changes were made to validations.yaml, make sure that yarn build has been run and the results committed
  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Passes all existing automated tests
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested

@tanner-ricks tanner-ricks changed the title Draft: Add Regtech Regex Support to Node Environments Add Regtech Regex Support to Node Environments Dec 12, 2024
@tanner-ricks tanner-ricks marked this pull request as ready for review December 12, 2024 21:08
@tanner-ricks tanner-ricks marked this pull request as draft December 12, 2024 22:09
@tanner-ricks tanner-ricks marked this pull request as ready for review December 18, 2024 15:06
Copy link
Collaborator

@billhimmelsbach billhimmelsbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing that yarn issue, just a few comments for the readme, then we can try this out.

.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@billhimmelsbach billhimmelsbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good!

@tanner-ricks tanner-ricks merged commit 24d6fe5 into main Dec 19, 2024
3 checks passed
@tanner-ricks tanner-ricks deleted the 1069-regtech-regex-in-zod branch December 19, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants