This repository has been archived by the owner on Jan 7, 2020. It is now read-only.
Disclosure s3 server and select component #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awolfe76
reviewed
Apr 17, 2018
| @@ -59,7 +60,7 @@ | |||
| "eslint-config-react-app": "2.1.0", | |||
| "eslint-plugin-flowtype": "2.44.0", | |||
| "eslint-plugin-import": "2.8.0", | |||
| "eslint-plugin-jsx-a11y": "6.0.3", | |||
| "eslint-plugin-jsx-a11y": "5.1.1", | |||
There was a problem hiding this comment.
Why back to a previous version?
There was a problem hiding this comment.
eslint-config-react-app needs a 5.x version to work in all cases, my editor was showing a failure due to conflict on every file.
src/reports/Report.jsx
Outdated
| if (this.state.report === null) return null | ||
|
|
||
| const report = this.state.report | ||
| const headingText = report | ||
| ? `Table ${report.table}: ${report.description}, ${report.year}` | ||
| ? `Table ${this.props.match.params.reportId.split('.txt')[0]}: ${ |
There was a problem hiding this comment.
I think we should just use the report.table value here, since that data is loaded.
| } | ||
| import Selector from './Selector.jsx' | ||
|
|
||
| const Reports = props => { |
There was a problem hiding this comment.
I think this is ok for now, but we'll end up just having these values all listed, a constant.
There won't be an endpoint since all of the reports were created, even if they were filled with 0.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also against a-and d, built the work fleshing out the aggregate stuff (though that's broken now)
👀