Table heading css #143
Table heading css #143
Conversation
…ayout between the header and the reports
| headingText="MSA/MD Aggregate Reports" | ||
| paragraphText="These reports summarize lending activity by MSA/MD." | ||
| /> | ||
| ) | ||
|
|
||
| return ( | ||
| <> | ||
| <React.Fragment> |
There was a problem hiding this comment.
Any reason for the reintroduction of the longer fragment syntax?
There was a problem hiding this comment.
Not really ... the <> way causes my editor (Sublime) to do odd things and makes it hard to read.
| headingText="Disclosure reports" | ||
| paragraphText="These reports summarize lending activity for individual | ||
| institutions, both nationwide and by MSA/MD." | ||
| /> | ||
| ) | ||
|
|
||
| return this.state.fetched ? ( | ||
| <> | ||
| <React.Fragment> |
|
|
||
| const capitalize = str => str[0].toUpperCase() + str.slice(1) | ||
| const ProgressCard = ({ name, id, link, title }) => { | ||
| if (id === 'nationwide') { | ||
| name = '' |
There was a problem hiding this comment.
A nationwide id will still need to be capitalized here, though it could just be hardcoded as id = 'Nationwide'
|
I like the formatting changes , but I think I'd probably prefer to keep the light-gray background on the progress cards. Right now I feel like there isn't enough visual separation between the header, progress cards, and main page element. |
|
What do you think about adding a border or Example with
|
|
I think the Also, I think the idea of having all the steps available could be nice, but we'll just have to make sure the info in the inactive steps isn't too busy. I think a disabled, gray link and a gray, possibly italic "Select an institution" or "Select an Institution and MSA/MD" would do fine. |
Closes #131
This does some cleanup to improve the heading area throughout the report workflow; for both aggregate and disclosure reports.
<ol><ol>to give an idea of steps similar to the filing applicationScreenshot