Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update hero text margin to auto 0 #2127

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Update hero text margin to auto 0 #2127

merged 1 commit into from
Nov 26, 2024

Conversation

anselmbradford
Copy link
Member

@anselmbradford anselmbradford commented Nov 26, 2024 •
edited
Loading

Changes

  • Update hero text margin to auto 0.
  • Minor formatting of hero SCSS to align with newlines used between rules elsewhere.

Testing

  1. Visit the PR preview heroes page and see that a short hero heading text doesn't get centered at desktop sizes. https://deploy-preview-2127--cfpb-design-system.netlify.app/design-system/patterns/heroes

@netlify Netlify
Copy link

netlify bot commented Nov 26, 2024

✅ Thanks for the improvements! Browse a preview of your changes using the link below.

Name Link
🔨 Latest commit a731483
🔍 Latest deploy log https://app.netlify.com/sites/cfpb-design-system/deploys/67461a15973095000861ed67
😎 Deploy Preview https://deploy-preview-2127--cfpb-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

niqjohnson
niqjohnson approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@niqjohnson niqjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heroes with short text look correctly aligned with this fix, thanks

@anselmbradford anselmbradford merged commit a688ab9 into main Nov 26, 2024
8 checks passed
@anselmbradford anselmbradford deleted the ans_adjust_hero branch November 26, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niqjohnson niqjohnson niqjohnson approved these changes

@contolini contolini Awaiting requested review from contolini

Assignees
No one assigned
Labels
None yet
Projects
Active sprint board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anselmbradford @niqjohnson