Add button link example | Correctly vertically align button group link buttons #2085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Thanks for the improvements! Browse a preview of your changes using the link below.
To edit notification comments on pull requests, go to your Netlify site configuration. |
anselmbradford
commented
Oct 31, 2024
| @@ -5,4 +5,5 @@ | |||
| display: flex; | |||
| gap: math.div(10px, $base-font-size-px) + rem; | |||
| flex-wrap: wrap; | |||
| align-items: center; | |||
There was a problem hiding this comment.
We could also consider align-items: baseline for this, so that the button text and link text bottoms are aligned with each other.
7ebd7c9 to
7f38dc7
Compare
contolini
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a button is accompanied by a button link, the
m-btn-groupsets them to flexbox, but doesn't vertically align them.This PR sets the vertical alignment to
align-items: center.Changes
Testing