Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aria-hidden:true to SVG icons #2082

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Add aria-hidden:true to SVG icons #2082

merged 2 commits into from
Oct 30, 2024

Conversation

anselmbradford
Copy link
Member

@anselmbradford anselmbradford commented Oct 29, 2024 •
edited
Loading

Fixes #1965

Adjust SVGo config to add aria-hidden: true to SVG icons.

Changes

  • Add aria-hidden:true to SVG icons

Testing

  1. Icons should look like before, but when inspected would have an aria-hidden attribute.

@anselmbradford anselmbradford mentioned this pull request Oct 29, 2024
Closed
@netlify Netlify
Copy link

netlify bot commented Oct 29, 2024 •
edited
Loading

✅ Thanks for the improvements! Browse a preview of your changes using the link below.

Name Link
🔨 Latest commit 181bea2
🔍 Latest deploy log https://app.netlify.com/sites/cfpb-design-system/deploys/67226667f291bf00075cf112
😎 Deploy Preview https://deploy-preview-2082--cfpb-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

contolini
contolini approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@contolini contolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪄

@anselmbradford anselmbradford merged commit d804d8b into main Oct 30, 2024
8 checks passed
@anselmbradford anselmbradford deleted the ans_svg_icons branch October 30, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@contolini contolini contolini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Active sprint board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Icons: Are they always decorative?
2 participants
@anselmbradford @contolini