Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused Lighthouse results upload #2081

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Conversation

chosak
Copy link
Member

@chosak chosak commented Oct 28, 2024

A nightly GitHub Action runs Lighthouse against the Design System documentation site, to ensure that it meets with accessibility guidelines.

Currently this Action is generating a warning message, for example:

No files were found with the provided path: .lighthouseci. No artifacts will be uploaded.

This warning occurs because the upload step can't find the Lighthouse results.

We don't actually use the raw Lighthouse results in any way; as part of the nightly test, HTML reports are uploaded to temporary Google storage and their public URLs are included in the Action log.

Thus there's no need to upload the raw run results. This commit removes the upload step, thus fixing the warning.

A nightly GitHub Action runs Lighthouse against the Design System
documentation site, to ensure that it meets with accessibility
guidelines.

Currently this Action is generating a warning message, for example [0]:

> No files were found with the provided path: .lighthouseci.
> No artifacts will be uploaded.

This warning occurs because the upload step can't find the Lighthouse
results.

We don't actually use the raw Lighthouse results in any way; as part of
the nightly test, HTML reports are uploaded to temporary Google storage
and their public URLs are included in the Action log.

Thus there's no need to upload the raw run results. This commit removes
the upload step, thus fixing the warning.

[0] https://github.com/cfpb/design-system/actions/runs/11524988694
@chosak chosak requested a review from anselmbradford October 28, 2024 13:55
Copy link

netlify bot commented Oct 28, 2024

Thanks for the improvements! Browse a preview of your changes using the link below.

Name Link
🔨 Latest commit 0fae44b
🔍 Latest deploy log https://app.netlify.com/sites/cfpb-design-system/deploys/671f97ebc734560007ab2815
😎 Deploy Preview https://deploy-preview-2081--cfpb-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@chosak chosak merged commit 524c55d into main Oct 29, 2024
8 checks passed
@chosak chosak deleted the fix/lighthouse-warning branch October 29, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants