-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new tooltip component to DS #2054
Merged
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
b718f49
Add new tooltip component to DS
contolini e7d8d57
Rebuild dist bundles
contolini e09b28c
Update tooltips page content
contolini 005bce9
Add exports config to DS package
contolini 4f50825
Update deps based on new Yarn v4 config options
contolini eb584f8
Hide tooltip trigger elements if JS is disabled
contolini 979f268
Change cursor to pointer on tooltip trigger hover
CFPBot e0e9531
Rebuild assets, move new packages to yarn cache dir
contolini 0a07cbc
Kill old yarn cache folder
contolini 980d9eb
Remove erroneous auto-changelog dependency and config
contolini File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file not shown.
Binary file not shown.
Binary file renamed
BIN
+17.6 KB
...spawn-npm-7.0.5-cf92562a27-aa82ce7ac0.zip → ...spawn-npm-7.0.3-e4ff3e65b3-5738c31238.zip
Binary file not shown.
Binary file renamed
BIN
+149 KB
...mium-npm-1.5.45-985999020d-f361ceda3b.zip → ...mium-npm-1.5.43-ed44a171d1-d13f271f80.zip
Binary file not shown.
Binary file not shown.
Binary file renamed
BIN
+672 KB
...table-npm-5.0.2-d7d3c3ff6b-0d97ad9538.zip → ...table-npm-5.0.3-c4195fd7f3-3269827789.zip
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file renamed
BIN
+5.4 MB
...sass-npm-1.80.4-604cd1b502-58ca0f2d10.zip → ...sass-npm-1.80.3-4465a3ce7e-fa08043fc3.zip
Binary file not shown.
Binary file not shown.
Binary file renamed
BIN
+231 KB
...core-npm-6.1.58-647b54f6b2-aadb37cad8.zip → ...core-npm-6.1.65-aeca149aeb-8e08eec0e8.zip
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,91 @@ | ||
--- | ||
title: Tooltips | ||
collection_name: pages | ||
layout: variation | ||
section: components | ||
status: Beta | ||
description: A tooltip provides short, descriptive information when a user | ||
hovers or focuses on an element. It contains helpful but non-critical | ||
information and is useful in a space-constrained user interface. | ||
variation_groups: | ||
- variations: | ||
- variation_is_deprecated: false | ||
variation_code_snippet: >- | ||
The APR for the World Bank Platinum Credit Card is 9.7% <span | ||
data-tooltip="relevant-tooltip">{% include icons/help-round.svg | ||
%}</span> | ||
|
||
|
||
<template id="relevant-tooltip"> | ||
<div class="tippy-heading">This data is accurate as of June 2023</div> | ||
<div class="tippy-body"> | ||
APRs change over time and are specific to the applicant. Check rates before applying. | ||
</div> | ||
</template> | ||
|
||
|
||
<!-- | ||
|
||
Tooltips require a <template> element with an 'id' that matches the 'data-tooltip' | ||
|
||
attribute of the tooltip's trigger element. The template can be anywhere on the page. | ||
|
||
|
||
Additionally, the tooltip component must be imported independently of the rest of | ||
|
||
the Design System using the namespace '@cfpb/cfpb-design-system/tooltips'. | ||
|
||
For example, your project's JavaScript file might look like: | ||
|
||
|
||
import { | ||
Expandable, | ||
ExpandableGroup, | ||
Summary, | ||
Multiselect, | ||
} from '@cfpb/cfpb-design-system'; | ||
|
||
import { Tooltip } from '@cfpb/cfpb-design-system/tooltips'; | ||
|
||
|
||
Summary.init(); | ||
|
||
Expandable.init(); | ||
|
||
ExpandableGroup.init(); | ||
|
||
Multiselect.init(); | ||
|
||
Tooltip.init(); | ||
|
||
|
||
...rest of your code | ||
|
||
--> | ||
variation_description: '' | ||
variation_code_snippet_rendered: '' | ||
variation_group_name: Standard tooltip | ||
variation_group_description: '' | ||
guidelines: Be judicious in using tooltips and explore other design options that | ||
keep content visible before choosing to use a tooltip. Only consider using a | ||
tooltip for short, non-critical information in a space-constrained user | ||
interface. Because a tooltip is hidden until activated, ensure content within | ||
a tooltip is not essential for completing a task on the page. The tooltip | ||
trigger element (usually a help icon) will be hidden for users with JavaScript | ||
disabled. For more guidance, see the [USWDS tooltip | ||
page](https://designsystem.digital.gov/components/tooltip/). | ||
eyebrow: Components | ||
behavior: > | ||
- Activate a tooltip by hovering or focusing on a help (question mark) icon | ||
situated next to text. | ||
|
||
- Press the escape key to dismiss open tooltips. | ||
|
||
- When a tooltip is at the edge of the user’s viewport, it should automatically reorient itself away from the edge of the screen to prevent content clipping. | ||
accessibility: As USWDS states, tooltips are progressive enhancements for the | ||
title attribute and will display as the title attribute if the component | ||
doesn’t initialize. When testing tooltips for accessibility, ensure they are | ||
compliant with [USWDS tooltip accessibility | ||
tests](https://designsystem.digital.gov/components/tooltip/accessibility-tests/). | ||
related_items: '' | ||
--- |
3 changes: 3 additions & 0 deletions
3
packages/cfpb-design-system/dist/components/cfpb-tooltips/index.css
Large diffs are not rendered by default.
Oops, something went wrong.
7 changes: 7 additions & 0 deletions
7
packages/cfpb-design-system/dist/components/cfpb-tooltips/index.css.map
Large diffs are not rendered by default.
Oops, something went wrong.
2 changes: 2 additions & 0 deletions
2
packages/cfpb-design-system/dist/components/cfpb-tooltips/index.js
Large diffs are not rendered by default.
Oops, something went wrong.
7 changes: 7 additions & 0 deletions
7
packages/cfpb-design-system/dist/components/cfpb-tooltips/index.js.map
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
79 changes: 79 additions & 0 deletions
79
packages/cfpb-design-system/src/components/cfpb-tooltips/index.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,79 @@ | ||
/* ========================================================================== | ||
Tooltip Organism | ||
========================================================================== */ | ||
|
||
import tippy from 'tippy.js'; | ||
import { instantiateAll } from '@cfpb/cfpb-design-system'; | ||
|
||
import * as TooltipStyles from './tooltip.scss'; | ||
|
||
const BASE_ATTRIBUTE = 'data-tooltip'; | ||
|
||
/** | ||
* Tooltip | ||
* @class | ||
* @classdesc Initializes a new Tooltip. | ||
* @param {HTMLElement} element - The DOM element that should | ||
* activate the tooltip. | ||
* @returns {Tooltip} An instance. | ||
*/ | ||
function Tooltip(element) { | ||
const tooltipContent = element.getAttribute(BASE_ATTRIBUTE); | ||
|
||
/** | ||
* Set up and create the tooltip. | ||
* @returns {Tooltip} An instance. | ||
*/ | ||
function init() { | ||
tippy(element, { | ||
theme: 'cfpb', | ||
maxWidth: 450, | ||
content: function (reference) { | ||
const template = reference.parentElement.querySelector( | ||
`#${tooltipContent}`, | ||
); | ||
const container = document.createElement('div'); | ||
const node = document.importNode(template.content, true); | ||
container.appendChild(node); | ||
return container; | ||
}, | ||
// See https://atomiks.github.io/tippyjs/v6/plugins/ | ||
plugins: [ | ||
{ | ||
name: 'hideOnEsc', | ||
defaultValue: true, | ||
fn({ hide }) { | ||
/** | ||
* Hide when the escape key is pressed. | ||
* @param {KeyboardEvent} event - Key down event. | ||
*/ | ||
function onKeyDown(event) { | ||
if (event.key === 'Escape') { | ||
hide(); | ||
} | ||
} | ||
return { | ||
onShow() { | ||
document.body.addEventListener('keydown', onKeyDown); | ||
}, | ||
onHide() { | ||
document.body.removeEventListener('keydown', onKeyDown); | ||
}, | ||
}; | ||
}, | ||
}, | ||
], | ||
}); | ||
} | ||
|
||
// Attach public events. | ||
this.init = init; | ||
|
||
return this; | ||
} | ||
|
||
Tooltip.BASE_ATTRIBUTE = BASE_ATTRIBUTE; | ||
Tooltip.init = (scope) => | ||
instantiateAll(`[${Tooltip.BASE_ATTRIBUTE}]`, Tooltip, scope); | ||
|
||
export { Tooltip, TooltipStyles }; |
36 changes: 36 additions & 0 deletions
36
packages/cfpb-design-system/src/components/cfpb-tooltips/tooltip.scss
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
@use 'sass:math'; | ||
@use '@cfpb/cfpb-design-system/src/abstracts' as *; | ||
@use 'tippy.js/dist/tippy.css'; | ||
@use 'tippy.js/dist/border.css'; | ||
|
||
// Custom theme, see https://atomiks.github.io/tippyjs/v6/themes/ | ||
.tippy-box[data-theme='cfpb'] { | ||
background-color: var(--gray-5); | ||
border: 1px solid var(--gray-40); | ||
border-radius: 0; | ||
color: var(--black); | ||
padding: math.div(15px, $base-font-size-px) + rem; | ||
|
||
.tippy-arrow { | ||
color: var(--gray-5); | ||
} | ||
|
||
.tippy-heading { | ||
font-weight: 500; | ||
font-size: math.div(18px, $base-font-size-px) + rem; | ||
} | ||
|
||
.tippy-body { | ||
font-size: math.div(16px, $base-font-size-px) + rem; | ||
margin-top: math.div(15px, $base-font-size-px) + rem; | ||
} | ||
} | ||
|
||
[data-tooltip] { | ||
cursor: pointer; | ||
|
||
// Hide tooltip trigger elements when JS isn't supported | ||
.no-js & { | ||
display: none; | ||
} | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be removed