Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a-legend class | Move legends inside fieldsets #2009

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

anselmbradford
Copy link
Member

The a-legend class was just an h4 with additional IE legacy CSS. With the legacy CSS removed it just becomes an h4, so best to just set <legend class="h4"> instead.

Removals

  • Remove a-legend class

Changes

  • Move legends inside fieldsets

Testing

  1. Check the PR preview legends page and it should be unchanged from production.

Copy link

netlify bot commented Aug 2, 2024

Thanks for the improvements! Browse a preview of your changes using the link below.

Name Link
🔨 Latest commit 58d078a
🔍 Latest deploy log https://app.netlify.com/sites/cfpb-design-system/deploys/66ad3a16438b6400081f9b43
😎 Deploy Preview https://deploy-preview-2009--cfpb-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@contolini contolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I support simplicity

@anselmbradford anselmbradford merged commit b9a6a9b into main Aug 6, 2024
8 checks passed
@anselmbradford anselmbradford deleted the ans_legend branch August 6, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lerna-changelog/breaking lerna label. DO NOT MODIFY
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants