Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate netlify-cms to decap-cms #1980

Merged
merged 2 commits into from
Aug 8, 2024
Merged

Migrate netlify-cms to decap-cms #1980

merged 2 commits into from
Aug 8, 2024

Conversation

anselmbradford
Copy link
Member

netlify-cms has migrated to decap-cms https://www.netlify.com/blog/netlify-cms-to-become-decap-cms/

Changes

  • Migrate netlify-cms to decap-cms

Testing

  1. yarn start should run a local server at localhost:4000/design-system, where you can edit pages.

Copy link

netlify bot commented May 16, 2024

Thanks for the improvements! Browse a preview of your changes using the link below.

Name Link
🔨 Latest commit 1b24686
🔍 Latest deploy log https://app.netlify.com/sites/cfpb-design-system/deploys/66b4cc3e1cdc3e00088fce01
😎 Deploy Preview https://deploy-preview-1980--cfpb-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@anselmbradford anselmbradford force-pushed the ans_decap branch 3 times, most recently from 55d885f to 0ad3aa7 Compare May 16, 2024 15:51
@anselmbradford anselmbradford force-pushed the ans_decap branch 4 times, most recently from 4c3f805 to 2241f67 Compare May 16, 2024 17:56
@anselmbradford anselmbradford force-pushed the ans_decap branch 2 times, most recently from 001e3ae to 6fca5b0 Compare July 10, 2024 19:14
@anselmbradford anselmbradford force-pushed the ans_decap branch 2 times, most recently from e640ee0 to 79252b4 Compare July 18, 2024 15:50
@anselmbradford anselmbradford added lerna-changelog/internal lerna label. DO NOT MODIFY and removed lerna-changelog/internal lerna label. DO NOT MODIFY labels Aug 6, 2024
@anselmbradford anselmbradford force-pushed the ans_decap branch 3 times, most recently from 656aa90 to 4dd8418 Compare August 7, 2024 13:49
.frame-content {
padding-left: 20px;
padding-right: 20px;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this entire file be deleted now that decap.scss exists? And import it in main.scss.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmm yes indeed d842395

import { StringTrimmedControl } from './widgets/StringTrimmed.js';
import { StringWithInstructionsControl } from './widgets/StringWithInstructions.js';
import genericPreviewTemplate from './widgets/genericPreviewTemplate.js';
import navigationPreviewTemplate from './widgets/navigationPreviewTemplate.js';
import pagePreviewTemplate from './widgets/pagePreviewTemplate.js';

CMS.init();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's weird that we need to initialize the CMS when the docs state that it's only necessary when the CMS_MANUAL_INIT flag is enabled. 🤷

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is weird! But if I remove it the CMS screen is a blank screen 🤷

@anselmbradford anselmbradford force-pushed the ans_decap branch 2 times, most recently from 3e31a9f to e045b46 Compare August 8, 2024 13:42
@contolini contolini self-requested a review August 8, 2024 14:36
Copy link
Member

@contolini contolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants