Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress: Update gradpath dollar amount that is checked to match up with production #8728

Closed
wants to merge 2 commits into from
Closed

Cypress: Update gradpath dollar amount that is checked to match up with production #8728

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea06c6e
Update gradpath dollar amount that is checked to match up with produc…
anselmbradford Jan 28, 2025
aef5c4a
Update financial-path.cy.js
anselmbradford Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...ess/integration/paying-for-college/your-financial-path-to-graduation/financial-path.cy.js
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file requires two additional changes because of the changing numbers:

Line 94: $28 instead of $138
Line 111: $3,902 instead of $2,998

I've checked these numbers in the calculations using the new data, so they are correct (given our methods).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm changed in aef5c4a, but looks like CI still wants it to be $12,596

Copy link
Member

@wpears wpears Jan 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to update stuff in test.sql.gz since that's what's compared in CI

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you'll update this originally? With a cursory search I'm not seeing the values in financial-path.cy.js in test.sql.

Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ describe('Paying For College', () => {
);
cy.get('span[data-financial-item="total_costOfProgram"]').should(
'contain',
'$12,596',
'$2,152',
);
});
it('does not advance without valid selections', () => {
Expand Down Expand Up @@ -91,7 +91,7 @@ describe('Paying For College', () => {

cy.get('[data-financial-item="debt_tenYearMonthly"]').should(
'contain',
'$138',
'$28',
);
});

Expand All @@ -108,7 +108,7 @@ describe('Paying For College', () => {

cy.get('[data-financial-item="debt_tenYearMonthly"]').should(
'contain',
'$2,998',
'$3,902',
);
});
});
Expand Down
Loading