Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove o-featured-content-module--left #8660

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Remove o-featured-content-module--left #8660

merged 1 commit into from
Nov 27, 2024

Conversation

anselmbradford
Copy link
Member

This pattern appears to have been usurped by the 25/75 info unit pattern. It was not possible to set this in Wagtail, as there was no option to set it. It is only set in the debug template view.

Accompanying DS PR cfpb/design-system#2128

Removals

  • Remove o-featured-content-module--left

How to test this PR

  1. View http://localhost:8000/admin/template_debug/v1/featured_content/ and see that the left aligned version is gone.

Notes

On arabic pages, the FCM maybe should flip, but this should happen without the need to add a modifier.
(e.g. https://www.consumerfinance.gov/language/ar/)

@anselmbradford anselmbradford added this pull request to the merge queue Nov 27, 2024
Merged via the queue into main with commit 025934a Nov 27, 2024
11 checks passed
@anselmbradford anselmbradford deleted the ans_left_fcm branch November 27, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants