Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DATAP-1476 Add Aggregation.less stylesheet to SimpleFilter component #524

Conversation

cdmh219
Copy link
Collaborator

@cdmh219 cdmh219 commented Aug 6, 2024

During conversion of SimpleFilter to functional component, the reference for the Aggregation.less stylesheet was missed, resulting in various styling issues. This needs to be added in to resolve them.

Additions

-Aggregation.less

Removals

Changes

Testing

Screenshots

Screenshot 2024-08-06 at 12 30 44 PM

Notes

Todos

Checklist

  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows the standards laid out in the front end playbook
  • Passes all existing automated tests
  • New functions include new tests
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged
  • Visually tested in supported browsers and devices
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

@cdmh219 cdmh219 requested a review from flacoman91 August 6, 2024 16:31
@flacoman91 flacoman91 added this pull request to the merge queue Aug 6, 2024
Merged via the queue into main with commit 29ae4ec Aug 6, 2024
2 checks passed
@flacoman91 flacoman91 deleted the DATAP-1476-Add-Aggregation.less-reference-into-SimpleFIlter-functional-component branch August 6, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants