Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DATAP-1341 - Restore row chart functionality on map tab #523

Merged
merged 3 commits into from
Aug 2, 2024
Merged

DATAP-1341 - Restore row chart functionality on map tab #523

merged 3 commits into from
Aug 2, 2024

Conversation

cdmh219
Copy link
Collaborator

@cdmh219 cdmh219 commented Aug 2, 2024 •
edited
Loading

Bug Fix - Row Chart in Map page not expandable

Additions

Removals

Changes

  • Functionality for addition of new item to expandedRows (from mutable to immutable)

Testing

Screenshots

Screenshot 2024-08-02 at 3 02 24 PM

Notes

Todos

Checklist

  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows the standards laid out in the front end playbook
  • Passes all existing automated tests
  • New functions include new tests
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged
  • Visually tested in supported browsers and devices
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

@cdmh219 cdmh219 marked this pull request as ready for review August 2, 2024 19:02
flacoman91
flacoman91 reviewed Aug 2, 2024
View reviewed changes
src/reducers/view/view.js
newState = {
...state,
expandedRows,
};
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we're not modifying anything, should we just return state ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes good catch! This has been updated accordingly.

@cdmh219 cdmh219 changed the title Made fix to use immutable functionality to add new items to the expan… DATAP-1341 - Restore row chart functionality on map tab Aug 2, 2024
@flacoman91 flacoman91 added this pull request to the merge queue Aug 2, 2024
Merged via the queue into main with commit 1049e64 Aug 2, 2024
2 checks passed
@flacoman91 flacoman91 deleted the ch-bugfix-map-rowchart-not-expanding branch August 2, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flacoman91 flacoman91 flacoman91 approved these changes

@anselmbradford anselmbradford Awaiting requested review from anselmbradford

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cdmh219 @flacoman91