Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies: design-system@0.39.0, babel/core@7.24.0, cypress@13.6.6, eslint@8.57.0, eslint-plugin-jsdoc@48.2.1, mini-css-extract-plugin@2.8.1, postcss-preset-env@9.5.0 #493

Merged
merged 7 commits into from
Mar 28, 2024

Conversation

anselmbradford
Copy link
Member

@anselmbradford anselmbradford commented Mar 13, 2024

Brings in latest DS changes cfpb/design-system@v0.37.2...v0.39.0

Changes

  • Update dependencies: design-system@0.39.0, babel/core@7.24.0, cypress@13.6.6, eslint@8.57.0, eslint-plugin-jsdoc@48.2.1, mini-css-extract-plugin@2.8.1, postcss-preset-env@9.5.0

  • Update filter CSS to accommodate changes in expandable default padding.

  • Update filter CSS to integrate a-form-error class for date error messages.

Testing

  • PR checks should pass.
  • Click around the filters to see the margin changes.
  • Add the same date filter in both filters to show error message.

@anselmbradford
Copy link
Member Author

The latest DS update merges o-expandable__padded into the default expandable, which required some adjustments to the CSS. This changes (and improves, I think) some of the spacing in the filters:

Before:
Screenshot 2024-03-13 at 11 16 38 AM

After:
Screenshot 2024-03-13 at 11 16 29 AM

@anselmbradford
Copy link
Member Author

Error message changes

Before:
Screenshot 2024-03-13 at 11 43 11 AM

After:
Screenshot 2024-03-13 at 11 42 58 AM

Copy link
Contributor

@flacoman91 flacoman91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my apologies for not reviewing this sooner!!

Looks great!

@anselmbradford anselmbradford added this pull request to the merge queue Mar 28, 2024
Merged via the queue into main with commit 6cc5912 Mar 28, 2024
2 checks passed
@anselmbradford anselmbradford deleted the ans_update_deps branch March 28, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants