Skip to content

Commit

Permalink
Merge pull request #309 from flacoman91/accessibility-updates
Browse files Browse the repository at this point in the history
Accessibility updates
  • Loading branch information
sephcoster authored Jul 10, 2020
2 parents 1bce7d6 + 2d04a5f commit 736d575
Show file tree
Hide file tree
Showing 16 changed files with 15 additions and 40 deletions.
1 change: 0 additions & 1 deletion src/__tests__/__snapshots__/App.spec.jsx.snap
Original file line number Diff line number Diff line change
Expand Up @@ -1215,7 +1215,6 @@ exports[`initial state renders without crashing 1`] = `
<button
className="a-btn"
onClick={[Function]}
title="Close Filters"
>
Close Filters
</button>
Expand Down
2 changes: 1 addition & 1 deletion src/components/Charts/LineChart.less
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@
p {
font-size: 12px;
font-weight: 600;
color: @gray-80;
color: @gray;

&.y-axis-label {
margin-left: @gutter-normal;
Expand Down
2 changes: 1 addition & 1 deletion src/components/Charts/StackedAreaChart.less
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
p {
font-size: 12px;
font-weight: 600;
color: @gray-80;
color: @gray;

&.y-axis-label {
margin-left: @gutter-normal;
Expand Down
3 changes: 3 additions & 0 deletions src/components/DateInput/DateInput.less
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,7 @@
.a-text-input {
padding-right: @grid_gutter-width;
}
.a-btn {
color: @gray;
}
}
3 changes: 1 addition & 2 deletions src/components/Filters/AggregationBranch.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,7 @@ export class AggregationBranch extends React.Component {
<span className="u-visually-hidden">{item.key}</span>
</label>
<button className="flex-all a-btn a-btn__link"
onClick={this._toggleChildDisplay}
title={item.key}>
onClick={this._toggleChildDisplay}>
<span>{item.key}</span>
{chevronIcon}
</button>
Expand Down
2 changes: 0 additions & 2 deletions src/components/Filters/FilterPanelToggle.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ export class FilterPanelToggle extends React.Component {
<p>&nbsp;</p>
<button
className={ 'a-btn' }
title={ this.props.showFilters ? 'Close Filters' :
'Filter results' }
onClick={ () => this.props.onFilterToggle() }>
{ this.props.showFilters ? 'Close Filters' : 'Filter results' }
</button>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ exports[`component::AggregationBranch snapshots renders with all checked 1`] = `
<button
className="flex-all a-btn a-btn__link"
onClick={[Function]}
title="foo"
>
<span>
foo
Expand Down Expand Up @@ -161,7 +160,6 @@ exports[`component::AggregationBranch snapshots renders with indeterminate 1`] =
<button
className="flex-all a-btn a-btn__link"
onClick={[Function]}
title="foo"
>
<span>
foo
Expand Down Expand Up @@ -294,7 +292,6 @@ exports[`component::AggregationBranch snapshots renders with none checked 1`] =
<button
className="flex-all a-btn a-btn__link"
onClick={[Function]}
title="foo"
>
<span>
foo
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,6 @@ exports[`component:Issue snapshots only shows the first five items 1`] = `
<button
className="flex-all a-btn a-btn__link"
onClick={[Function]}
title="Incorrect information on credit report"
>
<span>
Incorrect information on credit report
Expand Down Expand Up @@ -155,7 +154,6 @@ exports[`component:Issue snapshots only shows the first five items 1`] = `
<button
className="flex-all a-btn a-btn__link"
onClick={[Function]}
title="Cont'd attempts collect debt not owed"
>
<span>
Cont'd attempts collect debt not owed
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ exports[`component:Product snapshots only shows the first five items 1`] = `
<button
className="flex-all a-btn a-btn__link"
onClick={[Function]}
title="Credit reporting, credit repair services, or other personal consumer reports"
>
<span>
Credit reporting, credit repair services, or other personal consumer reports
Expand Down Expand Up @@ -116,7 +115,6 @@ exports[`component:Product snapshots only shows the first five items 1`] = `
<button
className="flex-all a-btn a-btn__link"
onClick={[Function]}
title="Mortgage"
>
<span>
Mortgage
Expand Down
8 changes: 8 additions & 0 deletions src/components/List/ListPanel.less
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,12 @@
h2 {
padding: @gutter-normal;
}

.m-pagination {
.a-btn[disabled],
.m-pagination_label,
.m-pagination_btn-submit {
color: @gray;
}
}
}
2 changes: 1 addition & 1 deletion src/components/RefineBar/RefineBar.less
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
p {
font-size: @size-vi;
font-weight: 600;
color: @gray-40;
color: @gray;
}
button {
&.selected {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ exports[`initial state renders without crashing 1`] = `
<button
className="a-btn"
onClick={[Function]}
title="Filter results"
>
Filter results
</button>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@ exports[`component:ListPanel displays a message when an error has occurred 1`] =
<button
className="a-btn"
onClick={[Function]}
title="Filter results"
>
Filter results
</button>
Expand Down Expand Up @@ -377,7 +376,6 @@ exports[`component:ListPanel displays a message when only the narratives are sta
<button
className="a-btn"
onClick={[Function]}
title="Filter results"
>
Filter results
</button>
Expand Down Expand Up @@ -857,7 +855,6 @@ exports[`component:ListPanel displays a message when the data has issues 1`] = `
<button
className="a-btn"
onClick={[Function]}
title="Filter results"
>
Filter results
</button>
Expand Down Expand Up @@ -1337,7 +1334,6 @@ exports[`component:ListPanel displays a message when the data is stale 1`] = `
<button
className="a-btn"
onClick={[Function]}
title="Filter results"
>
Filter results
</button>
Expand Down Expand Up @@ -1792,7 +1788,6 @@ exports[`component:ListPanel displays a message when there are no results 1`] =
<button
className="a-btn"
onClick={[Function]}
title="Filter results"
>
Filter results
</button>
Expand Down Expand Up @@ -2077,7 +2072,6 @@ exports[`component:ListPanel only displays data message when both types are stal
<button
className="a-btn"
onClick={[Function]}
title="Filter results"
>
Filter results
</button>
Expand Down Expand Up @@ -2533,7 +2527,6 @@ exports[`component:ListPanel renders mobile filters without crashing 1`] = `
<button
className="a-btn"
onClick={[Function]}
title="Filter results"
>
Filter results
</button>
Expand Down Expand Up @@ -2988,7 +2981,6 @@ exports[`component:ListPanel renders without crashing 1`] = `
<button
className="a-btn"
onClick={[Function]}
title="Filter results"
>
Filter results
</button>
Expand Down
3 changes: 0 additions & 3 deletions src/components/__tests__/__snapshots__/MapPanel.spec.jsx.snap
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@ exports[`component:MapPanel renders Print without crashing 1`] = `
<button
className="a-btn"
onClick={[Function]}
title="Filter results"
>
Filter results
</button>
Expand Down Expand Up @@ -295,7 +294,6 @@ exports[`component:MapPanel renders warning without crashing 1`] = `
<button
className="a-btn"
onClick={[Function]}
title="Filter results"
>
Filter results
</button>
Expand Down Expand Up @@ -480,7 +478,6 @@ exports[`component:MapPanel renders without crashing 1`] = `
<button
className="a-btn"
onClick={[Function]}
title="Filter results"
>
Filter results
</button>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,6 @@ exports[`component:Results renders List print mode without crashing 1`] = `
<button
className="a-btn"
onClick={[Function]}
title="Filter results"
>
Filter results
</button>
Expand Down Expand Up @@ -597,7 +596,6 @@ exports[`component:Results renders Map print mode without crashing 1`] = `
<button
className="a-btn"
onClick={[Function]}
title="Filter results"
>
Filter results
</button>
Expand Down Expand Up @@ -797,7 +795,6 @@ exports[`component:Results renders list panel without crashing 1`] = `
<button
className="a-btn"
onClick={[Function]}
title="Filter results"
>
Filter results
</button>
Expand Down Expand Up @@ -1255,7 +1252,6 @@ exports[`component:Results renders map panel without crashing 1`] = `
<button
className="a-btn"
onClick={[Function]}
title="Filter results"
>
Filter results
</button>
Expand Down Expand Up @@ -1444,7 +1440,6 @@ exports[`component:Results renders trends panel without crashing 1`] = `
<button
className="a-btn"
onClick={[Function]}
title="Filter results"
>
Filter results
</button>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@ exports[`component:TrendsPanel Snapshots renders Focus without crashing 1`] = `
<button
className="a-btn"
onClick={[Function]}
title="Filter results"
>
Filter results
</button>
Expand Down Expand Up @@ -489,7 +488,6 @@ exports[`component:TrendsPanel Snapshots renders area without crashing 1`] = `
<button
className="a-btn"
onClick={[Function]}
title="Filter results"
>
Filter results
</button>
Expand Down Expand Up @@ -872,7 +870,6 @@ exports[`component:TrendsPanel Snapshots renders company Overlay without crashin
<button
className="a-btn"
onClick={[Function]}
title="Filter results"
>
Filter results
</button>
Expand Down Expand Up @@ -1268,7 +1265,6 @@ exports[`component:TrendsPanel Snapshots renders date warning without crashing 1
<button
className="a-btn"
onClick={[Function]}
title="Filter results"
>
Filter results
</button>
Expand Down Expand Up @@ -1533,7 +1529,6 @@ exports[`component:TrendsPanel Snapshots renders external Tooltip without crashi
<button
className="a-btn"
onClick={[Function]}
title="Filter results"
>
Filter results
</button>
Expand Down Expand Up @@ -1916,7 +1911,6 @@ exports[`component:TrendsPanel Snapshots renders lineChart Overview without cras
<button
className="a-btn"
onClick={[Function]}
title="Filter results"
>
Filter results
</button>
Expand Down Expand Up @@ -2182,7 +2176,6 @@ exports[`component:TrendsPanel Snapshots renders mobile filters without crashing
<button
className="a-btn"
onClick={[Function]}
title="Filter results"
>
Filter results
</button>
Expand Down Expand Up @@ -2447,7 +2440,6 @@ exports[`component:TrendsPanel Snapshots renders print mode without crashing 1`]
<button
className="a-btn"
onClick={[Function]}
title="Filter results"
>
Filter results
</button>
Expand Down

0 comments on commit 736d575

Please sign in to comment.