Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevents admin credentials from being logged in cleartext #307

Merged
merged 1 commit into from
Jul 29, 2019

Conversation

ktpv
Copy link
Contributor

@ktpv ktpv commented Apr 27, 2019

No description provided.

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

@keshto
Copy link
Contributor

keshto commented Apr 29, 2019

Looks good, would it be too hard to get a test for this so that;

  1. We know the change did what it is supposed to
  2. Catch any violation in the future

@keshto
Copy link
Contributor

keshto commented Jul 12, 2019

There has been no activity in awhile and PR will be closed next week.

@keshto keshto merged commit 78740ad into cf-platform-eng:master Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants