Easier l4 health checks - without singleton #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- create a common singleton like struct fot l4 health checks - new struct holds mutex for common resources - delete shared healtcheck firewall rules safely
address review comments, improve tests, added mutex guard preventing re-initialization of L4 healhtchecks, renamed a few places, added comments It is important that all controllers in a single test case use the same fakeHC, I have fixed this in TestHealthCheckFirewallDeletionWithILB TestHealthCheckFirewallDeletionWithNetLB
address review comments, improve tests, added mutex guard preventing re-initialization of L4 healhtchecks, renamed a few places, added comments It is important that all controllers in a single test case use the same fakeHC, I have fixed this in TestHealthCheckFirewallDeletionWithILB TestHealthCheckFirewallDeletionWithNetLB
570dc6e to
a10c879
Compare
eccf309 to
abf0c05
Compare
91c10b1 to
f8353dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
created on top of
kubernetes#1705
this is just to show if removing singleton pattern from healthchecks gives any benefits