Add PUT, PATCH, DELETE and cookie support #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @mna! Sorry I forgot about this PR until today. I made some adjustments here -- the main thing is that we can't rely on the FS test to check different methods like DELETE because http.FileServer has been changing how it responds to different methods in recent Go versions (see golang/go#53501 and golang/go#59470). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies for the README formatting changes, I just realized my editor automatically made some header changes. Apart from that and the aforementioned new features, it also improves code coverage a bit and removes a couple of unused, unexported functions.