Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alert name representation #108

Merged
merged 20 commits into from
Dec 23, 2024
Merged

Conversation

Lorygold
Copy link
Collaborator

No description provided.

ManofWax
ManofWax previously approved these changes Dec 20, 2024
@Lorygold Lorygold closed this Dec 20, 2024
Copy link

@lucaCigarini lucaCigarini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ti ho lasciato due commenti (proprio di numero). Il resto mi sembra tutto ok

buffalogs/buffalogs/settings/certego.py Outdated Show resolved Hide resolved
buffalogs/impossible_travel/tests/test_tasks.py Outdated Show resolved Hide resolved
@Lorygold
Copy link
Collaborator Author

@lucaCigarini ti segnalo l'aggiunta del campo Config.ignored_ISPs di default lista vuota popolabile con liste di stringhe di ISPs, commit sopra: 15e935b

Mi era sfuggito nel modello, l'avevo messo solo nella Enum, scusami

@lucaCigarini
Copy link

No problem, poi lo aggiungo anche al portale 💪

ManofWax
ManofWax previously approved these changes Dec 23, 2024
@Lorygold Lorygold merged commit 0a84768 into develop Dec 23, 2024
2 checks passed
@Lorygold Lorygold deleted the fix_alert_name_representation branch December 23, 2024 11:36
Lorygold added a commit that referenced this pull request Dec 23, 2024
* Cleaned venv from useless packages (#103)

* Cleaned venv from useless packages

* Added pytz required in celery_beat

* fix

* Updated CHANGELOG.md

* Registered UserAdmin for authentication app in admin.py

* Configuration panel (#104)

* [refactor] Added enums in new costants.py file for "choices" fields in the models

* [refactor] Added default config values in the django settings (certego.py file)

* Added default configs in settings

* Updated CHANGELOG.md

* [test-view] Ignore alerts order for views return API

* Fixed linters paths

* Changed "null=True" to "blank=True" for Charfields

* changes for flake8 linter

* Revoed E231 flake8 rule for certego.py file

* removed comment

* Updated CHANGELOG.md

* [CI] Updated to compose v2

* fix

* Alerts fields utilities (#105)

* Added method to get the alert name label, for tagging

* Added ipython for develop

* Added new fields in login_raw_data for more info about previous login

* Updated CHANGELOG.md

* Version 1.3.0

* Force one config object (#107)

* Forced only 1 Config object presence

* Set always Config.id=1

* Updated CHANGELOG.md

* Fix alert name representation (#108)

* Fixed alert.name representation enums

* Cleaned enum

* Set short_name to choose

* Added forms for multiple choices array

* fix

* Added style in order to show the choices selected in django-admin multiple choices field Config.filtered_alerts_types

* Added forms to handle multiple choice fields

* Added constraints for multiple choices fields check

* Fixed risk_score admin display

* Added user.risk_Score choice constraint

* Added timestamp representations for seconds

* Fixed enums

* Added test migration in order to convert data in Alert with the new Alert.name "shorter version"

* Fix

* Included again E231 flake8 rule, but removed in some code lines with: # noqa: E231

* Fixes

* Added config.ignored_ISPs list field

* Fixed Rabbit url

* Added null=True for Config list fields

* Completed test

* Updated CHANGELOG.md

* Version 1.3.1

* Updated some Python dapendencies (#110)

* Updated some Python dapendencies

* fix

* Version 1.3.1 fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants