Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: bump pytest-xdist to 1.22.4 #6253

Merged
merged 1 commit into from
Jul 31, 2018
Merged

deps: bump pytest-xdist to 1.22.4 #6253

merged 1 commit into from
Jul 31, 2018

Conversation

greut
Copy link
Contributor

@greut greut commented Jul 24, 2018 •
edited
Loading

Latest pytest-xdist knows how to properly read the number of processes given by Travis.

cf #6236, reverts #6211

@greut
Copy link
Contributor Author

greut commented Jul 24, 2018

😕

plugins: xdist-1.22.3, forked-0.2, cov-2.5.1
gw0 [877] / gw1 [877] / gw2 [877] / gw3 [877] / gw4 [877] / gw5 [877] / gw6 [877] / gw7 [877] / gw8 [877] / gw9 [877] / gw10 [877] / gw11 [877] / gw12 [877] / gw13 [877] / gw14 [877] / gw15 [877] / gw16 [877] / gw17 [877] / gw18 [877] / gw19 [877] / gw20 [877] / gw21 [877] / gw22 [877] / gw23 [877] / gw24 [877] / gw25 [877] / gw26 [877] / gw27 [877] / gw28 [877] / gw29 [877] / gw30 [877] / gw31 [877] / gw32 [877] / gw33 [877] / gw34 [877] / gw35 [877] / gw36 [877] / gw37 [877] / gw38 [877] / gw39 [877] / gw40 [877] / gw41 [877] / gw42 [877] / gw43 [877] / gw44 [877] / gw45 [877] / gw46 [877] / gw47 [877]

@greut
Copy link
Contributor Author

greut commented Jul 24, 2018

Python 2.7, of course.

@bmw
Copy link
Member

bmw commented Jul 26, 2018

Ah. I didn't realize os.sched_getaffinity was Python 3 only. We could move some tests over to Python 3, but we can't eliminate Python 2.7 tests right now.

We may have a solution when pytest-dev/pytest-xdist#317 is released though.

bmw
bmw requested changes Jul 27, 2018
View reviewed changes
Copy link
Member

@bmw bmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than my inline comment, this LGTM! Thanks again @greut.

Now that pytest-dev/pytest-xdist#318 has landed, tests should pass when you submit followup commits.

tox.ini Outdated
@@ -121,7 +121,7 @@ commands =

[testenv:cover]
basepython = python2.7
passenv = NUMPROCESSES
passenv = TRAVIS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to setting this here, I think we should set it in the [testenv] environment and inherit it in all of the [testenv:py27-*oldest] environments like we do for setenv. This should cause the variable to be passed through for all relevant Python 2.7 tests.

@greut greut force-pushed the bump-pytest-xdist branch 2 times, most recently from 8db3377 to 0487276 Compare July 30, 2018 06:50
@greut greut changed the title deps: bump pytest-xdist to 1.22.3 deps: bump pytest-xdist to 1.22.4 Jul 30, 2018
@greut
Copy link
Contributor Author

greut commented Jul 30, 2018

bumping pytest leads to all sorts of trouble with tox -e py27-oldest

@bmw
Copy link
Member

bmw commented Jul 30, 2018

bumping pytest leads to all sorts of trouble with tox -e py27-oldest

Looks like they require a newer version six than is available for us for our CentOS 7 packaging. Can we just bump pytest-xdist and not pytest?

@greut
Copy link
Contributor Author

greut commented Jul 31, 2018

@bmw it requires pytest>=3.3

@bmw
Copy link
Member

bmw commented Jul 31, 2018

I think this requirement was removed in pytest-xdist 1.22.5. See pytest-dev/pytest-xdist#321.

bump pytest-xdist to 1.22.5
60d3807 
Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>
@greut greut force-pushed the bump-pytest-xdist branch from d3abe8f to 60d3807 Compare July 31, 2018 14:10
@greut
Copy link
Contributor Author

greut commented Jul 31, 2018

yay 👍

bmw
bmw approved these changes Jul 31, 2018
View reviewed changes
Copy link
Member

@bmw bmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay indeed! Thanks a lot for the PRs here and against pytest-xdist for this @greut.

@bmw bmw merged commit 6262921 into certbot:master Jul 31, 2018
This was referenced Jul 31, 2018
Closed
Merged
@greut greut deleted the bump-pytest-xdist branch July 31, 2018 18:02
@bmw bmw mentioned this pull request Nov 16, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmw bmw bmw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@greut @bmw